Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR for stats #2248

Closed
wants to merge 1 commit into from
Closed

PR for stats #2248

wants to merge 1 commit into from

Conversation

annegu
Copy link

@annegu annegu commented Mar 27, 2024

No description provided.

@kovidgoyal
Copy link
Owner

What is this for? And remove the README and the unused import in add.py

Copy link
Contributor

@eli-schwartz eli-schwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kovidgoyal , the PR title is, with a slight rewording, "creating a PR in order to get the github stats of having created a PR that got merged".

Comment on lines -1683 to +1687
if not DEBUG:
return
from time import monotonic
if not hasattr(timed_print, 'startup_time'):
timed_print.startup_time = monotonic()
print(f'[{monotonic() - timed_print.startup_time:.2f}]', *a, **kw)
if DEBUG:
from time import monotonic
if not hasattr(timed_print, 'startup_time'):
timed_print.startup_time = monotonic()
print(f'[{monotonic() - timed_print.startup_time:.2f}]', *a, **kw)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This in particular is just changing

if not X:
    return
Y

to

if X:
    Y

and I call either spam or noise.

@kovidgoyal kovidgoyal closed this Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants